search

DARMA-tasking / LB-analysis-framework

Analysis framework for exploring, testing, and comparing load balancing strategies
Other
3 stars 1 forks source link

#392: Make pylint errors cause a CI failure #395

Closed cwschilly closed 1 year ago

cwschilly commented 1 year ago

Fixes: #392

cwschilly commented 1 year ago

There is still one pylint error: src/lbaf/Applications/rank_object_enumerator.py:27:25: E1101: Instance of 'LoadReader' has no 'read' member (no-member) @ppebay Is there a different function that has taken on the functionality of "read"?

ppebay commented 1 year ago

There is still one pylint error: src/lbaf/Applications/rank_object_enumerator.py:27:25: E1101: Instance of 'LoadReader' has no 'read' member (no-member) @ppebay Is there a different function that has taken on the functionality of "read"?

Indeed @cwschilly, good catch, this is now entirely outdated as the LoadReader was deprecated and replaced by the VTDataReader with updated execution logic (especially re: new vt JSON scheme).

This stand-alone script is to be deprecated (as part of an ongoing discussion with @tlamonthezie in #386 ) so we should ignore this error until the script goes away entirely.

cwschilly commented 1 year ago

Looking good. Cf. my answer to your question @cwschilly

Thank you @ppebay . Should I disable the pylint error in the code so that it ignores it, or should I keep it as it is (and we just ignore the failing test)?