DARMA-tasking / LB-analysis-framework

Analysis framework for exploring, testing, and comparing load balancing strategies
Other
3 stars 1 forks source link

#388: print list of implemented qois #405

Closed cwschilly closed 1 year ago

cwschilly commented 1 year ago

Fixes #388

cwschilly commented 1 year ago

In #388, @nlslatt requested to print the list of implemented QOI when a .yaml contains an invalid QOI (in order to be more user-friendly). However, the current error message already prints the invalid QOI (see attached). Should I still change the output so it prints the list?

image

cwschilly commented 1 year ago

Here is the (end of the) output with lbaf -v 2 image

cwschilly commented 1 year ago

Here is the output for lbaf -v 1 image

cwschilly commented 1 year ago

@ppebay I have altered the code so it outputs all possible QOI. Here is the new output with lbaf -v 2. I implemented it such that it will automatically adjust for any changes in lbsRank.py or lbsObject.py (for example known_loads no longer exists in lbsRank.py, but will automatically be removed from this list when the code is merged into Develop)

Screenshot from 2023-06-15 13-30-08

ppebay commented 1 year ago

@cwschilly changes looking good!

Minor formatting suggestions: 1- use Rank: and Object: (instead of the capitalized versions thereof) 2- using a second level of indentation for the actual QOI names under Rank: and Object

ppebay commented 1 year ago

Looking good, this PR can be now made Ready for review