DARMA-tasking / LB-analysis-framework

Analysis framework for exploring, testing, and comparing load balancing strategies
Other
3 stars 1 forks source link

#370: make categorical labels integers #407

Closed cwschilly closed 1 year ago

cwschilly commented 1 year ago

Fixes #370

cwschilly commented 1 year ago

This fix appears to work, but I'm not sure how to test with data that would yield decimal labels. @nlslatt , if you have a sample config file that produced the problem in #370 , please include it here so that I can test out this solution.

ppebay commented 1 year ago

Any update @cwschilly on testing this PR?

cwschilly commented 1 year ago

@ppebay No update yet; if there is a sample config file that produces the error, that would be great to be able to test on. I also still have to make the changes we discussed in the meeting yesterday, but I will do that hopefully this afternoon

ppebay commented 1 year ago

Thanks @cwschilly I added @nlslatt as reviewer

cwschilly commented 1 year ago

This will print labels like "1.0" and "2.0" as "1" and "2", but any other decimals (like "1.5") are still printed as such.