search

DARMA-tasking / LB-analysis-framework

Analysis framework for exploring, testing, and comparing load balancing strategies
Other
3 stars 1 forks source link

#464: Improve efficiency of cluster swap stage of clustering transfer strategy #451

Closed ppebay closed 10 months ago

ppebay commented 11 months ago

Resolves #464

Related to #446

ppebay commented 11 months ago

@nlslatt if you get a chance (and time), this branch contains performance improvements to the swapping stage of the clustering transfer strategy. I added some stats (and fixed some that turned out to be incorrect regarding rejection rates), so any feedback as to whether execution speed is improved with your data sets would be appreciated.

Meanwhile I am continuing to work on the sub-clustering stage. Thanks

ppebay commented 10 months ago

As discussed with @nlslatt and @lifflander this is ready to be reviewed

nlslatt commented 10 months ago

@ppebay You should open an issue that motivates your changes and link it to that issue instead of the one that you don't want closed.

nlslatt commented 10 months ago

@ppebay It also looks like you have commits from other PRs on this branch. Please rebase and make sure the branch is clean.

ppebay commented 10 months ago

Thanks @nlslatt this is now fixing #464

Regarding the commits from other branches, this is because this branch was rebased on develop twice in order to incorporate other changes along the way.

ppebay commented 10 months ago

This is now superseded by new PR #465