DARMA-tasking / LB-analysis-framework

Analysis framework for exploring, testing, and comparing load balancing strategies
Other
5 stars 1 forks source link

#527: Update JSON generator to work with vt's LBDataHolder #528

Closed tlamonthezie closed 2 months ago

tlamonthezie commented 2 months ago

Fixes #527 Fixes #531

This PR provides the following changes;

  1. Add packed id support in entities 1.2 The Object class -> __index renamed as seq_id, + addition of a packed_id field
  2. Add collection_id field 2.1 Object class: Add the collection_id field to the attributes of the Object class, add objgroup_id field to unused params. 2.2 JSON Generator: Enable the collection_id field to be set by the JSON generator (JSONDataFilesMaker) (with interactive mode support) 2.3 set collection_id automatically with some default value of 7 if object is added as migratable to a rank (collection_id required by vt for migratable objects so required for the LBAF Json writer). _with the help of the new TaskSpecificationtyped dict defining both time(required) and collection_id (not required)_
  3. VTDataWriter: copy object fields to the entity node inside the communication from or to nodes
  4. Adapt unit tests (code, config) to work with these source updates
  5. Update data sets with small entity ids by replacing id by seq_id (considering small ids sequences are in fact seg_id's) regenerate to get data in communiaction endpoints nodes and add some generator config file
  6. Replace shared_block_id by shared_id everywhere

Note: this PR is also needed to adapt to the new LB Data files schema defined by VT PR 2243

IMPORTANT: vt-tv must be updated as well to support seq_id as object identifiers. Else we have to generate entity id values in LBAF if missing in input data

ppebay commented 2 months ago

Requesting now a SNL review @nlslatt @lifflander due to connection with vt

tlamonthezie commented 2 months ago

531 now included in the PR