DARMA-tasking / LB-analysis-framework

Analysis framework for exploring, testing, and comparing load balancing strategies
Other
4 stars 1 forks source link

Investigate removing `estimate` method in CriterionBase #550

Open cwschilly opened 2 months ago

cwschilly commented 2 months ago

As mentioned in PR #546

CriterionBase defines an estimate method, but it may not be used.

def estimate(self, r_src: Rank, o_src: list, *args) -> float:
        """Estimate is compute because all information is local for this criterion."""
        return self.compute(r_src, o_src, *args)

Investigate if we can just remove the estimate method entirely.