search

DARMA-tasking / vt

DARMA/vt => Virtual Transport
Other
35 stars 8 forks source link

#2147: fix incorrect order of parameters for call to beginProcessing #2148

Closed nmm0 closed 1 year ago

nmm0 commented 1 year ago

Closes #2147

I'm going to see if it is possible to add some tests, since we don't have any trace tests.

github-actions[bot] commented 1 year ago

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for f8a80b55cdc069355f5e1110ccd177dac2b3b496 (2023-05-18 19:59:16 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for f8a80b55cdc069355f5e1110ccd177dac2b3b496 (2023-05-18 19:59:16 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for f8a80b55cdc069355f5e1110ccd177dac2b3b496 (2023-05-18 19:59:16 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for f8a80b55cdc069355f5e1110ccd177dac2b3b496 (2023-05-18 19:59:16 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for f8a80b55cdc069355f5e1110ccd177dac2b3b496 (2023-05-18 19:59:16 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for f8a80b55cdc069355f5e1110ccd177dac2b3b496 (2023-05-18 19:59:16 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for f8a80b55cdc069355f5e1110ccd177dac2b3b496 (2023-05-18 19:59:16 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for f8a80b55cdc069355f5e1110ccd177dac2b3b496 (2023-05-18 19:59:16 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for f8a80b55cdc069355f5e1110ccd177dac2b3b496 (2023-05-18 19:59:16 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for f8a80b55cdc069355f5e1110ccd177dac2b3b496 (2023-05-18 19:59:16 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for f8a80b55cdc069355f5e1110ccd177dac2b3b496 (2023-05-18 19:59:16 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for f8a80b55cdc069355f5e1110ccd177dac2b3b496 (2023-05-18 19:59:16 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for f8a80b55cdc069355f5e1110ccd177dac2b3b496 (2023-05-18 19:59:16 UTC)

Compilation - successful

Testing - passed

Build log

PhilMiller commented 1 year ago

Should the PR description be made a bit more comprehensive?

PhilMiller commented 1 year ago

Trivial remarks aside, this looks good to me.