search

DARPA-ASKEM / GoLLM

Service to run GoLLM and define its tools.
Apache License 2.0
1 stars 0 forks source link

Fixed model card data type #43

Closed jryu01 closed 4 months ago

jryu01 commented 4 months ago

Description

Updated data type for the compare models input data type. There was a validation error occurring on model compare request since terrarium taskrunner sends the input payload with { model_cards: [...] } while this service expects { cards: [...] }. This change fixes the issue.

Related PR: https://github.com/DARPA-ASKEM/terarium/pull/4024

Resolves #(issue)

j2whiting commented 4 months ago

@kbirk this was changed because "model_" is a protected namespace in Pydantic and it was throwing warnings. I imagine you could just change the service since this would likely reintroduce the warnings.

kbirk commented 4 months ago

Didn't realize this was an external change. @jryu01 Let's change the hmi-server side of it.

Here: https://github.com/DARPA-ASKEM/terarium/blob/356f8eb964f1f2f2a5bd31a1f49496e14523b9df/packages/server/src/main/java/software/uncharted/terarium/hmiserver/service/tasks/CompareModelsResponseHandler.java#L23

jryu01 commented 4 months ago

Yeap then I'll make the change in the hmi-sever side

jryu01 commented 4 months ago

The change will be made in hmi-server closing the issue.