search

DARPA-ASKEM / Model-Representations

Modeling framework representations for ASKEM
https://darpa-askem.github.io/Model-Representations/
8 stars 2 forks source link

18 model properties #21

Closed liunelson closed 1 year ago

liunelson commented 1 year ago

Added (or moved) "name" and "description" properties, wherever missing, to the model object property list of the Petri Net and Reg Net frameworks. Also updated the examples.

liunelson commented 1 year ago

@mehalter Thanks for the review. I'll hold off on this issue though until the refactor PR gets merged.

liunelson commented 1 year ago

@mehalter I've also reverted syntax_edge_cases.json back to the original.

Also the syntax_edge_cases.json file should be left as it is. It is intentionally missing data because all of these fields are strictly not required to have a valid model. It is there to make sure that models with these missing fields or partially present fields are still 1. validated by our JSON Schema and 2. can be used for performers to test that their serialization/deserialization scripts actually work against the JSON Schema rather than people assuming these optional fields to exist.

liunelson commented 1 year ago

@mehalter I've made all the changes that you pointed out. If no other issue, this PR should be good to be merged.

mehalter commented 1 year ago

I'll review it again tomorrow.

liunelson commented 1 year ago

Looks great! I agree with the changes that were made. Could you do the rebase on the new main branch after the refactor and I can take another look at it just as a sanity check and get this merged in. Thanks @liunelson !

This PR can be closed since I accidentally included these changes in the "type info" PR.