search

DARPA-ASKEM / Model-Representations

Modeling framework representations for ASKEM
https://darpa-askem.github.io/Model-Representations/
8 stars 2 forks source link

Fix error in infection flux of sir_typed.json #53

Open djinnome opened 1 year ago

djinnome commented 1 year ago

$inf = \beta\frac{[S]\cdot[I]}{[S] + [I] + [R]}$

So, 

"expression": "S*I*beta/(S+I+R)",

instead of

"expression": "S*I*beta",
jpfairbanks commented 1 year ago

The SIR example doesn't divide by N.

https://github.com/DARPA-ASKEM/Model-Representations/blob/c0b064e478b940933824e5f7f2a9a815e849865b/petrinet/examples/sir.json#L88

There are no units in this model. So I don't this this is an error. I think this model is just written in terms of concentrations rather than populations.