search

DARPA-ASKEM / Model-Representations

Modeling framework representations for ASKEM
https://darpa-askem.github.io/Model-Representations/
8 stars 2 forks source link

Grigoriev example is out of sync with spec #82

Open fivegrant opened 5 months ago

fivegrant commented 5 months ago

The example Decapode in decapodes/example/grigoriev doesn't validate with the current schema. Additionally, decapodes/example/grigoriev/data may be missing a few files

fivegrant commented 5 months ago

Note that it might be because the ACSet needs to be used for the AMR instead of the DecaExpr

lukem12345 commented 5 months ago

Hey @fivegrant , can you share the script(s) that you used to generate the json files in decapodes/examples/grigoriev

fivegrant commented 5 months ago

The examples were generated by @liunelson and @mattprintz . I just modified configuration.json, context.json, and combined.json very slightly to make sure the InterTypes for context and configuration aligned.

lukem12345 commented 5 months ago

As discussed during today’s meeting, I’ll be shifting off the work on this issue to implement and document more physics examples. Anyone who gets this notification can pick up the work of finishing the generating script for the artifacts stored in the Grigoriev example folder. See PR#83