Ensembles as parametric types of Simulate/Calibrate

DARPA-ASKEM / sciml-service

Simulation Service provides an interface and job runner for ASKEM models.

MIT License

3 stars 1 forks source link

Ensembles as parametric types of Simulate/Calibrate #152

Closed jClugstor closed 9 months ago

jClugstor commented 9 months ago

Right now the Ensemble structs are parametric, and hold a list of operations that are either simulate/calibrate objects. Knowing more about ensembles lately, I think this is not very useful, and ends up making the solving functions for the ensembles more complicated than they need to be. Especially ensemble calibrate, which really isn't a bunch of ensemble operations, it's more of it's own thing.

I propose making two different structs, EnsembleSimulate, and EnsembleCalibrate.

joshday commented 9 months ago

Sounds good to me!

jClugstor commented 9 months ago

fixed by https://github.com/DARPA-ASKEM/sciml-service/pull/153