search

DARPA-ASKEM / sciml-service

Simulation Service provides an interface and job runner for ASKEM models.
MIT License
3 stars 1 forks source link

Error message for failing to create model in model-equation endpoint #173

Open jClugstor opened 2 months ago

jClugstor commented 2 months ago

https://github.com/DARPA-ASKEM/sciml-service/issues/172

@joshday I'm not super familiar with Oxygen and the HTTP response stuff but I think this is right. Could you make sure this looks right?

joshday commented 2 months ago

A few comments:

  1. The HTTP response looks correct.
  2. We'd want the catch block to rethrow the exception so that it shoes up in the sciml-service logs.
  3. I'm not sure this behavior is preferred to just returning 500. All this does is change errors in amr_get from 500 to 422.
joshday commented 2 months ago

What could we do in terms of validating the MathML?