DARPA-ASKEM / terarium

https://app.terarium.ai
Apache License 2.0
14 stars 2 forks source link

[TASK]: Look into pyciemss-service and Rabbit MQ to sort out typing #1757

Closed Tom-Szendrey closed 1 year ago

Tom-Szendrey commented 1 year ago

When Pyciemss is writing to RabbitMQ it is only receiving it as a btye[] This is different as to when we send it we can write it as an object. We can then read it back as a string deserialized into our object again

Tom-Szendrey commented 1 year ago

You will need to update pyciemss-service. You will have some rabbit MQ library to read up on and there should likely be a flag for them to be writing as String rather than Byte[]

Once the pyciemss-service is updated you will need to update our hmi-server

https://github.com/DARPA-ASKEM/Terarium/blob/0b1249484ceb507fe9c196a136801c91c373736d/packages/services/hmi-server/src/main/java/software/uncharted/terarium/hmiserver/resources/dataservice/SimulationResource.java#L168

1) This channel needs its type updated partialSimulationStream 2) the stream function does too 3) the try catch stuff in the stream function can be removed as all of that typing will happen as we are reading it in instead

Tom-Szendrey commented 1 year ago

Now that we are moving to Spring this seems irrelevant due to deserializing with ObjectMapper anyways