DARPA-ASKEM / terarium

https://app.terarium.ai
Apache License 2.0
13 stars 2 forks source link

Updating output metadata should not create a new ouptut #4040

Closed YohannParis closed 1 month ago

YohannParis commented 3 months ago

When updating metadata on output of an operator, do not create a new output but update the current one.

Slack Message

YohannParis commented 2 months ago

Let's meet with @blanchco and @mwdchang on wednesday to talk about it in detail.

mwdchang commented 2 months ago

@YohannParis there are maybe a few different things rolled up in here - can we explicitly define what is the ask here? Because these things may have conflicting interests.

  1. Objects with fields that are "editable". We have some notions of objects that can be edited after-the-fact, for example description and source fields in metadata for a model. These are information-only fields and generally speaking have no impact down stream.

  2. Updating output-port after the fact. This is generally discouraged because it is easy for things to start going out of sync. For example updating the output would require a mirror-ed update against the linked inputs. More generally speaking the only field that is safe to update is port.label.

  3. There is an idea of turning an anonymous output object into a "named" object that can be tracked as part of the project's manifest. This idea is not very well defined, in particular because we labelled this as "save as" and it is not entirely clear if the intention is to:

    • save object into new instance, as one typically associate with save-as mechanism, or
    • change the the object's editable attributes (see point-1) and make the object available in project space
dgauldie commented 2 months ago

linked with #4053

dgauldie commented 1 month ago

closing since we have created new issues for this task