DARPA-ASKEM / terarium

https://app.terarium.ai
Apache License 2.0
15 stars 2 forks source link

Simulation and Calibration should same output section as Optimize #4371

Closed Tom-Szendrey closed 1 month ago

Tom-Szendrey commented 2 months ago

Image

Image

Tom-Szendrey commented 2 months ago

Show mean for both simulation plot and interventions On by default

Tom-Szendrey commented 2 months ago

https://github.com/DARPA-ASKEM/terarium/pull/4457#issuecomment-2291477052

Some of the design elements are problematic, not really up-to-date with the latest thinking, or are some what contradictory. For example we'd need to think about how these settings are going to work with reporting features Likewise, the "chartConfig" is getting rejigged to take into consideration annotations, this will impact how we would pass things back and forth between the operator drilldown and the settings panel as they wouldn't be just variable string arrays It would still be good to assess the situation in a more systematic manner. It may be nice, if possible, for each operator to provide a generator function of its output-settings, and how the settings should be displayed.

Tom-Szendrey commented 2 months ago

Things to discuss: 1) Problematic design elements such as some sections of the form being filled in prior to run and others being filled in after.

2) Each drilldown has different charts. Does this design allow for that flexibility?

3) What designs for the reporting system and how will this impact our choices here? When a user hits add to report. This will create a copy of the current snapshot and send to the report. If the users reruns the operator, or changes the output settings this will not impact what has been added to the report.

4) Optimize, calibrate, and simulate utilize different ways of getting and displaying chart data. Do we want to uniform this? Do we want to use the chartConfig method vs the preparedCharts method? No. We can factor into individual util.ts though

5) Will all operators have this output settings? No. Some operators will not have this output settings section. Operators such as stratify will not.

6) User is unhappy with what was added to the report. What is the workflow?

7) Jaehwan to define chart config type

dgauldie commented 1 month ago

duplicate