[BUG]: Static intervention on state variable yields unexpected results + tweak to intervention description

DARPA-ASKEM / terarium

https://app.terarium.ai

Apache License 2.0

15 stars 2 forks source link

[BUG]: Static intervention on state variable yields unexpected results + tweak to intervention description #4952

Open pascaleproulx opened 1 month ago

pascaleproulx commented 1 month ago

Scenario: https://github.com/DARPA-ASKEM/terarium/blob/main/testing/manual/intervention-policy.md
Step: 9
Link to the project: https://app.staging.terarium.ai/projects/59d1af73-e373-42da-9e88-ac020a39cc1f/workflow/8f52229b-276a-474a-a534-f30d3c409f54?operator=aa816360-051e-41cf-9089-7c251b5524dd

Describe the issue The chart does not show I beeing set at 600 as per the intervention. Also, The intervention description should say `SEt the staten I to the value of 600 person at day 40.

liunelson commented 1 week ago

This is a known issue with how PyCIEMSS handles interventions: that is, it only checks if there is an intervention in the time period excluding the current time point, resulting in the intervention visibly manifesting after the time point at which it had been set. I've written an issue for them to tackle.

https://github.com/ciemss/pyciemss/issues/624