search

DARcorporation / xfoil-python

Stripped down version of XFOIL as compiled python module
GNU General Public License v3.0
87 stars 60 forks source link

State of the repository? #21

Closed sphh closed 3 years ago

sphh commented 3 years ago

I like this approach to XFoil!

@DARcorporation @danieldevriesdarcorp @daniel-de-vries @KikeM What is the state of this repository? There are many forks, which solves some bug, open PR but no activity for some years, so I wonder, if interest was lost.

And more importantly: How could we bring this up-to-date again? I would be happy to help, but would first like to check, what would be the best way.

Daniel, could you please state your intention, since you are the original owner/main contributor/originator of this repository?

KikeM commented 3 years ago

While we wait for @daniel-de-vries to get back to us, I would like to say that I am happy to maintain it and improve it, as back in the days it helped get some work done elegantly and effectively.

In my case what needs fixing in my repository is the installation, as for the moment I have to do a dirty workaround to get it installed on Mac OS.

sphh commented 3 years ago

What about making it a collaborative thing, so that the burden of maintaining is shared?

@daniel-de-vries: What do you think? Would this be an acceptable way to keep it alive?

Just in case that we need it: I created a new organization at codeberg.org (which I tend to use more often nowadays, because of known issues with github (and gitlab)) to reserve the name: https://codeberg.org/org/xfoil-python/

KikeM commented 3 years ago

What about making it a collaborative thing, so that the burden of maintaining is shared?

Sure, that's what I meant :)

Do you have any use case already in mind? This usually helps at focusing the functionality we want to maintain, add or remove.

sphh commented 3 years ago

At the moment I want to install it on Linux. Then I would need to compare two (custom) profiles – lift/drag curves and pressure distributions. In the long run, it might become part of a bigger package.

I am also interested in the design capabilities of XFoil.

DARcorporation commented 3 years ago

Greetings,

Daniel has left the company about 2 years ago and we have not updated any code since then. We probably would not be working on it until we have time to do so. If you wish to bring the code up to date, please feel free to do so.

Other than the information Daniel has posted, we do not have any other suggestions/recommendations at this point.

Thank you.

Max Yang Senior Aerospace Engineer Design, Analysis and Research Corporation 910 E 29th St Lawrence, KS 66046-4926 USA (785) 832-0434 x 105 www.darcorp.com https://www.darcorp.com/ @. @.>

https://www.darcorp.com/

https://www.facebook.com/DARcorporation/ https://twitter.com/DARcorporation https://www.youtube.com/user/darcorpks https://www.linkedin.com/company/9351192 CONFIDENTIALITY NOTICE - This communication may contain privileged or confidential information. If you are not the intended recipient or received this communication by error, please notify the sender and delete the message without copying, forwarding and/or disclosing it.

From: sphh @.> Sent: Tuesday, June 15, 2021 3:26 AM To: DARcorporation/xfoil-python @.> Cc: DARcorporation @.>; Mention @.> Subject: Re: [DARcorporation/xfoil-python] State of the repository? (#21)

At the moment I want to install it on Linux. Then I would need to compare two (custom) profiles – lift/drag curves and pressure distributions. In the long run, it might become part of a bigger package.

I am also interested in the design capabilities of XFoil.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DARcorporation/xfoil-python/issues/21#issuecomment-861296347 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AOLGBXEJNSA4CGMOBLRZJALTS4FDBANCNFSM46VKHDQQ . https://github.com/notifications/beacon/AOLGBXFICAA6LZXC5SRDRP3TS4FDBA5CNFSM46VKHDQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGNLFNWY.gif

sphh commented 3 years ago

Thanks, Max (@DARcorporation) for the update!

Would you mind, if we continue this as a community effort? You could become a contributor and get involved with your experience, whenever you find the time. If that is ok for you, we would copy the code over to a new repository, check all copyrights in the files, so that David and DARcorporation gets the proper credits. I would only ask, if we could use the same name on PyPi (I seem to remember, that there is a certain procedure to be followed, if a package name is to be transferred).

@KikeM: What do you think about working on this on codeberg? If you register there, I would enable you as an owner.

What do you think? Should we go forward as described?

daniel-de-vries commented 3 years ago

Hey guys! Sorry for the radio silence. As some of you mentioned, I have indeed not been able to keep up-to-date with what's going on here. As Max (@DARcorporation) mentioned, I left the company at which I developed this tool a few years ago and have been super busy since. My apologies for that.

My intent when making this tool open-source was always to get the community involved. As such, please feel free to take this tool wherever it needs to go to continue being useful for you. I only ask, like @sphh mentioned, that you guys respect the copyright and license associated with the project.

Logistically, as it comes to transferring ownership of PyPi naming etc, that decision will ultimately have to be made by @DARcorporation, since they hold the original copyright. I personally have no objections to this, as long as you guys carry on the development of this tool in the same spirit, keeping it free and open for all.

sphh commented 3 years ago

Thanks, @daniel-de-vries for your kind words.

I just copied it over to https://codeberg.org/xfoil-python/xfoil-python (it's an offer and if there are strong objections, please feel free to suggest a different place). @daniel-de-vries and @DARcorporation: Do you want to become also owner of the repository? If yes, please register and drop me a note. @KikeM: Please register too, so that I can make you owner of the new repository.

@daniel-de-vries @DARcorporation: I had a quick look through the files and noticed that the copyright notice is for Daniël de Vries throughout. Is that correct or should DAR Corporation be mentioned as well? Under which name?

daniel-de-vries commented 3 years ago

I registered for codeberg. My username there is daniel-de-vries. I would indeed very much appreciate being made an owner of the repo as well; it does feel a bit like my baby, if you know what I mean.

I am totally fine with moving the main development over to codeberg. I do think, despite its flaws, Github remains a very popular place for open-source software. So I suggest that we periodically synchronize the changes from codeberg over to Github. I am also happy to give one of you write access to the main repo here.

I thought the copyright notice already included DAR, but I see I was mistaken. DARCorporation, with that name, should be in there as well. Would you be able to change the files with a bulk replace such that they say: 

Copyright (c) 2019-2021 D. de Vries
Copyright (c) 2019 DARCorporation
Original Copyright (c) 2000 Mark Drela

Feel free to add yourselves above it as well when you've contributed a significant chunk of code. That way we all get credit for the work we've done :)

DARcorporation commented 3 years ago

Lower case c, so DARcorporation

Willem A. Anemaat, PhD President Design, Analysis and Research Corporation 910 E 29th St Lawrence, KS 66046-4926 USA (785) 832-0434 x 103 www.darcorp.com https://www.darcorp.com/
@. @.>

https://www.darcorp.com/

https://www.facebook.com/DARcorporation/ https://twitter.com/DARcorporation https://www.youtube.com/user/darcorpks https://www.linkedin.com/company/9351192 CONFIDENTIALITY NOTICE - This communication may contain privileged or confidential information. If you are not the intended recipient or received this communication by error, please notify the sender and delete the message without copying, forwarding and/or disclosing it.

From: Daniël de Vries @.> Sent: Thursday, June 17, 2021 10:54 AM To: DARcorporation/xfoil-python @.> Cc: DARcorporation @.>; Mention @.> Subject: Re: [DARcorporation/xfoil-python] State of the repository? (#21)

I registered for codeberg. My username there is daniel-de-vries. I would indeed very much appreciate being made an owner of the repo as well; it does feel a bit like my baby, if you know what I mean.

I am totally fine with moving the main development over to codeberg. I do think, despite its flaws, Github remains a very popular place for open-source software. So I suggest that we periodically synchronize the changes from codeberg over to Github. I am also happy to give one of you write access to the main repo here.

I thought the copyright notice already included DAR, but I see I was mistaken. DARCorporation, with that name, should be in there as well. Would you be able to change the files with a bulk replace such that they say:

Copyright (c) 2019-2021 D. de Vries Copyright (c) 2019 DARCorporation Original Copyright (c) 2000 Mark Drela

Feel free to add yourselves above it as well when you've contributed a significant chunk of code. That way we all get credit for the work we've done :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DARcorporation/xfoil-python/issues/21#issuecomment-863358778 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AOLGBXB3KKDTKOSTCCSIRKTTTIK75ANCNFSM46VKHDQQ . https://github.com/notifications/beacon/AOLGBXH5DPDTGXLTRFGI7I3TTIK75A5CNFSM46VKHDQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGN246OQ.gif

sphh commented 3 years ago

Oh, no! Now I have already changed it. But don't worry, I'll change it to a lower c!

sphh commented 3 years ago

@DARcorporation: Done.

KikeM commented 3 years ago

Hi!

I just registered at codeberg, my username is evalbuena.

sphh commented 3 years ago

Great! I added you as owner. Or do you want to be “just” a collaborator?

KikeM commented 3 years ago

I do not consider that I have made enough contributions to be considered an "owner" at this point, but I guess that if I am an "owner" in terms of source code management it might make some tasks easier (PRs, etc.).

Also, I would like to make a small disclaimer here, I am finishing my M. Sc. Thesis this summer, so until then my free time for these kind of things is limited :)

sphh commented 3 years ago

Hi @KikeM, hi @daniel-de-vries: I just made a stupid mistake: I removed myself from the list of owners. (You would have thought, that you were asked, if you really want to do it, but no – an accidental click with the mouse was enough!). Could anyone of you please add me again? Thanks! (user name is sph)

KikeM commented 3 years ago

hahaha I love how this project is starting, you put us together and then you leave :P

Done!

sphh commented 3 years ago

:joy: O well, that is my investigative mind! I simply have to try everything and that Leave button was too intriguing! What will be behind it? What will I leave? Who will leave? Will we leave everything behind?

BTW you added me as Administrator and not as owner :cry:

I already opened a bug report …

KikeM commented 3 years ago

I like your curious spirit! :)

Fixed! My apologies, I read the level I gave you in Spanish and guessed that in English the translation would be "owner", clearly not.

sphh commented 3 years ago

:bowing_man: