DASDAE / dascore

A python library for distributed fiber optic sensing
Other
72 stars 16 forks source link

fix_321 #324

Closed d-chambers closed 8 months ago

d-chambers commented 8 months ago

Description

Fixes #321 by adding logic to the Coord validation to raise an exception if stop-start doesn't have the same sign as step for evenly sampled monotonic coords (CoordRange).

Checklist

I have (if applicable):

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6d38342) 99.50% compared to head (50c19e1) 99.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #324 +/- ## ======================================= Coverage 99.50% 99.50% ======================================= Files 92 92 Lines 7130 7134 +4 ======================================= + Hits 7095 7099 +4 Misses 35 35 ``` | [Flag](https://app.codecov.io/gh/DASDAE/dascore/pull/324/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DASDAE/dascore/pull/324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | `99.50% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.