DASDAE / dascore

A python library for distributed fiber optic sensing
Other
72 stars 16 forks source link

add pep8 naming to ruff #330

Closed d-chambers closed 8 months ago

d-chambers commented 8 months ago

Description

This PR adds pep8 naming checks to ruff's configuration and fixes a few violations in the code base.

Checklist

I have (if applicable):

codecov[bot] commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9e39e0e) 99.51% compared to head (520508f) 99.51%.

Files Patch % Lines
dascore/io/tdms/utils.py 81.81% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #330 +/- ## ======================================= Coverage 99.51% 99.51% ======================================= Files 92 92 Lines 7159 7159 ======================================= Hits 7124 7124 Misses 35 35 ``` | [Flag](https://app.codecov.io/gh/DASDAE/dascore/pull/330/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DASDAE/dascore/pull/330/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | `99.51% <95.12%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

d-chambers commented 8 months ago

The patch coverage here isn't significant. I changed a line in TDMS that wasn't covered.