search

DASDAE / dascore

A python library for distributed fiber optic sensing
Other
72 stars 16 forks source link

Stacking #340

Closed d-chambers closed 8 months ago

d-chambers commented 8 months ago

Description

Opening this for @eileenrmartin and her work on implementing a spool.stack method for adding compatible patches in a spool together.

Checklist

I have (if applicable):

d-chambers commented 8 months ago

I think this PR may have found a bug in the CoordinateManager.update method regarding units. I will look into it tomorrow.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c0f415d) 99.52% compared to head (a8a0230) 99.53%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #340 +/- ## ======================================= Coverage 99.52% 99.53% ======================================= Files 91 91 Lines 7201 7242 +41 ======================================= + Hits 7167 7208 +41 Misses 34 34 ``` | [Flag](https://app.codecov.io/gh/DASDAE/dascore/pull/340/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DASDAE/dascore/pull/340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | `99.53% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

d-chambers commented 8 months ago

Summary of the small edits I made: