changed the RSF writer to byteorder Fortran due to RSF requirement

aaronjgirard commented 7 months ago

Description

The RSF writer was default output to C byteorder, but RSF requires Fortran byte order. This fixes that so Madagascar can read the outputs by default.

Checklist

I have (if applicable):

[x] referenced the GitHub issue this PR closes.
[x] documented the new feature with docstrings or appropriate doc page.
[x] included a test. See testing guidelines.
[x] your name has been added to the contributors page (docs/contributors.md).
[x] added the "ready_for_review" tag once the PR is ready to be reviewed.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (623e07e) 99.53% compared to head (01a2a0e) 99.53%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #343 +/- ## ======================================= Coverage 99.53% 99.53% ======================================= Files 91 91 Lines 7242 7242 ======================================= Hits 7208 7208 Misses 34 34 ``` | [Flag](https://app.codecov.io/gh/DASDAE/dascore/pull/343/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DASDAE/dascore/pull/343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | `99.53% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

d-chambers commented 7 months ago

Looks good. Did you want to change anything about how the time is stored in RSF files (if I recall correctly, that was the other thing keeping rsf output of DASCore from plotting) ? We can save that for a future PR but it should probably be given some more thought at some point.

aaronjgirard commented 7 months ago

Yes I have been thinking about this and didn't want to putz with it right now. I have some ideas but agree it should be a different PR.

Thanks!

Aaron Girard

On Sat, Jan 27, 2024, 10:50 Derrick Chambers @.***> wrote:

Looks good. Did you want to change anything about how the time is stored in RSF files (if I recall correctly, that was the other thing keeping rsf output of DASCore from plotting) ? We can save that for a future PR but it should probably be given some more thought at some point.

— Reply to this email directly, view it on GitHub https://github.com/DASDAE/dascore/pull/343#issuecomment-1913273885, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEX7T3Y3PMYPMUVLUGECQ6LYQU44XAVCNFSM6AAAAABCMXXK42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGI3TGOBYGU . You are receiving this because you authored the thread.Message ID: @.***>

DASDAE / dascore