search

DASDAE / dascore

A python library for distributed fiber optic sensing
Other
72 stars 16 forks source link

add OptoDAS support #347

Closed d-chambers closed 6 months ago

d-chambers commented 6 months ago

This PR implements OptoDAS support as requested in #345.

Checklist

I have (if applicable):

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.53%. Comparing base (1d49530) to head (aed81af).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #347 +/- ## ======================================= Coverage 99.53% 99.53% ======================================= Files 91 94 +3 Lines 7249 7337 +88 ======================================= + Hits 7215 7303 +88 Misses 34 34 ``` | [Flag](https://app.codecov.io/gh/DASDAE/dascore/pull/347/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DASDAE/dascore/pull/347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | `99.53% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

d-chambers commented 6 months ago

Merging this for now. @dylanmikesell if you run into any issues let me know and we can resolve in a different PR.

dylanmikesell commented 5 months ago

Thanks @d-chambers. I finally had some time this morning to test this. It works great on the whole dataset. Apologies for being so slow to test it.