Closed ahmadtourei closed 3 months ago
spool.chunk(Time=None)
raises a KeyError as below.
Unless you have renamed the dimension, it should be "time" not "Time", try again with
spool.chunk(time=None)
Ah, I see. I was in a rush and did not notice that typo. I think we can raise another KeyError for incorrect dimensions and also simply make dimensions not case-sensitive. What do you think?
I think we can raise another KeyError for incorrect dimensions
Ya, probably can raise a better error stating the patch doesn't have this coord/dimension.
also simply make dimensions not case-sensitive
Not so sure on this one. Ignoring case sensitivity smells too much like fortran ;)
Also, is spool.chunk(time=None)
expected to chunk the spool while there are gaps between patches? It seems it doesn't and just keep the spool size as is.
Need to set "tolerance" to a higher value to allow chunking when there are small gaps between patches. For example:
spool.chunk(time=None, tolerance=10)
Future work: To merge patches with big gaps, we need to lose the evenly sampled requirement and merge coords as are. We then need to make the spool evenly sampled by filling the gaps with NaNs or zeros.
Description
spool.chunk(Time=None)
raises a KeyError as below. However, all {'Time_min', 'Time_max', 'Time_step'} are there when printing the df columns and their values (see example below).Example
output:
Expected behavior
Versions