Closed aissah closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.54%. Comparing base (
c2f6ca7
) to head (d603999
). Report is 3 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Nice work @aissah, it looks very configurable. Do you mind posting an example of the output here so we can see what it looks like?
Can be reproduced with:
import dascore as dc
patch = dc.get_example_patch("random_patch_with_lat_lon")
patch = patch.set_units(latitude="ft", longitude="m")
ax = patch.viz.plot_map("latitude", "longitude", "distance")
How's this?
Looks great!
Except, why is latitude in ft and longitude in m?
A quick suggestion: since we don't use plot
in viz's modules (wiggle, waterfall, and spectrogram), I suggest using something like map_fiber
instead to make it consistent. What do you think?
Except, why is latitude in ft and longitude in m?
This was an arbitrary choice 😅 illustrating that they can have some units. Would you recommend I change it?
A quick suggestion: since we don't use
plot
in viz's modules (wiggle, waterfall, and spectrogram), I suggest using something likemap_fiber
instead to make it consistent. What do you think?
I think this is a good idea. What do you think @d-chambers ?
I think this is a good idea. What do you think @d-chambers
Ya, that sounds like a better name to me!
This was an arbitrary choice 😅 illustrating that they can have some units. Would you recommend I change it?
Nope, that's perfect. I just wanted to make sure it will use the correct units when we do an actual plot.
I think this is a good idea. What do you think @d-chambers
Ya, that sounds like a better name to me!
Done! I think we might be ready to merge after the checks
Description
I added "plot_map", a visualization function that plots the layout of a cable colored by a particular parameter.
Checklist
I have (if applicable):