Map plot

[aissah]

Description

I added "plot_map", a visualization function that plots the layout of a cable colored by a particular parameter.

Checklist

I have (if applicable):

• [ ] referenced the GitHub issue this PR closes.
• [x] documented the new feature with docstrings or appropriate doc page.
• [x] included a test. See testing guidelines.
• [x] your name has been added to the contributors page (docs/contributors.md).
• [ ] added the "ready_for_review" tag once the PR is ready to be reviewed.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.54%. Comparing base (c2f6ca7) to head (d603999). Report is 3 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #385 +/- ## ======================================= Coverage 99.54% 99.54% ======================================= Files 97 98 +1 Lines 7633 7700 +67 ======================================= + Hits 7598 7665 +67 Misses 35 35 ``` | [Flag](https://app.codecov.io/gh/DASDAE/dascore/pull/385/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DASDAE/dascore/pull/385/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | `99.54% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[d-chambers]

Nice work @aissah, it looks very configurable. Do you mind posting an example of the output here so we can see what it looks like?

[aissah]

Can be reproduced with:

import dascore as dc
patch = dc.get_example_patch("random_patch_with_lat_lon")
patch = patch.set_units(latitude="ft", longitude="m")
ax = patch.viz.plot_map("latitude", "longitude", "distance")

How's this?

[d-chambers]

Looks great!

[d-chambers]

Except, why is latitude in ft and longitude in m?

[ahmadtourei]

A quick suggestion: since we don't use plot in viz's modules (wiggle, waterfall, and spectrogram), I suggest using something like map_fiber instead to make it consistent. What do you think?

[aissah]

Except, why is latitude in ft and longitude in m?

This was an arbitrary choice 😅 illustrating that they can have some units. Would you recommend I change it?

A quick suggestion: since we don't use plot in viz's modules (wiggle, waterfall, and spectrogram), I suggest using something like map_fiber instead to make it consistent. What do you think?

I think this is a good idea. What do you think @d-chambers ?

[d-chambers]

I think this is a good idea. What do you think @d-chambers

Ya, that sounds like a better name to me!

[d-chambers]

This was an arbitrary choice 😅 illustrating that they can have some units. Would you recommend I change it?

Nope, that's perfect. I just wanted to make sure it will use the correct units when we do an actual plot.

[aissah]

I think this is a good idea. What do you think @d-chambers

Ya, that sounds like a better name to me!

Done! I think we might be ready to merge after the checks