DASDAE / dascore

A python library for distributed fiber optic sensing
Other
71 stars 16 forks source link

Path patch tutorial #386

Closed d-chambers closed 3 months ago

d-chambers commented 3 months ago

Description

The current cell in the Patch tutorial has been a bit confusing to users who often misunderstand the use of fetch to get DASCore's example file path. This PR hopefully improves the issue by folding the confusing bits of code.

Checklist

I have (if applicable):

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 99.75610% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.59%. Comparing base (654ee0f) to head (c2a466c).

Files Patch % Lines
dascore/core/coords.py 99.60% 1 Missing :warning:
dascore/utils/misc.py 98.61% 1 Missing :warning:
dascore/utils/models.py 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #386 +/- ## ========================================== + Coverage 99.54% 99.59% +0.05% ========================================== Files 97 98 +1 Lines 7647 8227 +580 ========================================== + Hits 7612 8194 +582 + Misses 35 33 -2 ``` | [Flag](https://app.codecov.io/gh/DASDAE/dascore/pull/386/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DASDAE/dascore/pull/386/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | `99.59% <99.75%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

d-chambers commented 3 months ago

oops, wrong base branch.