Modify chunk, select, and waterfall

ahmadtourei commented 2 months ago

Description

This PR addresses issues below:

Raise a nicer error message when non-ints are used in patch.select() when sample=True
380
Better handle raising an error when the key in spool.chunk() is not a valid dimension name
383
Logarithm support for viz.waterfall()
389

Checklist

I have (if applicable):

[ ] referenced the GitHub issue this PR closes.
[ ] documented the new feature with docstrings or appropriate doc page.
[ ] included a test. See testing guidelines.
[ ] your name has been added to the contributors page (docs/contributors.md).
[ ] added the "ready_for_review" tag once the PR is ready to be reviewed.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.57%. Comparing base (17fdfba) to head (0c890bb). Report is 3 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #392 +/- ## ========================================== + Coverage 99.54% 99.57% +0.03% ========================================== Files 97 101 +4 Lines 7647 7797 +150 ========================================== + Hits 7612 7764 +152 + Misses 35 33 -2 ``` | [Flag](https://app.codecov.io/gh/DASDAE/dascore/pull/392/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DASDAE/dascore/pull/392/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | `99.57% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ahmadtourei commented 2 months ago

I'm not sure why it failed because the test_select_basic test in "tests/test_core/test_coords.py" passes on my end. I'm on Ubuntu and using Python 3.12.3.

DASDAE / dascore