Closed d-chambers closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.84%. Comparing base (
d1dc874
) to head (52482bf
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I just realized the lag
parameter was already merged (#364 didn't introduce it), so we should go through a deprecation cycle before simply removing it.
Description
This PR changes the correlate function in a few ways:
lag
parameter as it was redundant (eg the user should do aselect
on the return value)patch.dft
Patch.conj
method for getting the complex conjugate of a patchPatch.correlate_shift
for undoing the fft-related shift and scalingsupersedes #364
Checklist
I have (if applicable):