Closed ahmadtourei closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.84%. Comparing base (
a59dc35
) to head (adc2a14
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @ahmadtourei,
I just looked over the code and it looks good. Also, thanks for correcting some of the misleading comments.
Description
This PR fixes two issues regarding the
center=True
in thePatch.rolling
function whenengine="numpy"
:-window//2
roll size instead of-(window//2)
innp.roll
function to roll NaN values. This could cause unequal NaNs at the beginning and end of the rolled patch.-(window//2)
instead of-(num_nans//2)
inside thenp.roll
that led to the wrong number of indices to roll when thestep
size is not equal toNone
(and therefore the size of the padded array is different than the original patch's data).Checklist
I have (if applicable):