DASDAE / dascore

A python library for distributed fiber optic sensing
Other
71 stars 16 forks source link

Fix 409 #410

Closed d-chambers closed 1 month ago

d-chambers commented 1 month ago

Description

This PR fixes the metadata retrieval issue mentioned in #409, but it does not implement the custom DAS event format. We can do that in a latter PR if we really need to.

Checklist

I have (if applicable):

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.84%. Comparing base (99f4468) to head (f5870f7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #410 +/- ## ======================================= Coverage 99.84% 99.84% ======================================= Files 109 109 Lines 8843 8843 ======================================= Hits 8829 8829 Misses 14 14 ``` | [Flag](https://app.codecov.io/gh/DASDAE/dascore/pull/410/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DASDAE/dascore/pull/410/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | `99.84% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.