Closed Shihao-Yuan closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.84%. Comparing base (
99f4468
) to head (32b7c18
). Report is 3 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @Shihao-Yuan,
The failure above is caused by incomplete test coverage. When you click on the details you can see the lines that aren't covered. In this case, the problem was with the case where the input patch was already in the FK domain.
I just pushed a couple of tweaks. Mainly, I grouped the internal logic of slope_filter
into sub functions just to improve organization. I also added some more tests and made the function general so it can work with dimensions of any name (not just time and distance).
Let me know what you think.
@Shihao-Yuan, feel free to squash and merge when you are happy with the PR.
Description
Implementing a frequency-wavenumber (F-K) filter to isolate seismic waves within a specified range of apparent velocities. This filter can also function as a directional filter, allowing for the selection of waves propagating in specific directions, such as upward/downward or leftward/rightward.
Relevant discussions #405
Checklist
I have (if applicable):