DFT padding and slope filter simplification

d-chambers commented 3 months ago

Description

This PR adds a pad argument to Patch.dft so that transformed dimensions can be padded to avoid slow lengths. It also simplifies some of the Patch.slope_filter implementation, as well as a few other improvements.

Checklist

I have (if applicable):

[ ] referenced the GitHub issue this PR closes.
[ ] documented the new feature with docstrings or appropriate doc page.
[ ] included a test. See testing guidelines.
[ ] your name has been added to the contributors page (docs/contributors.md).
[ ] added the "ready_for_review" tag once the PR is ready to be reviewed.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.84%. Comparing base (65fb430) to head (aac5933). Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #415 +/- ## ======================================= Coverage 99.84% 99.84% ======================================= Files 112 112 Lines 8980 9019 +39 ======================================= + Hits 8966 9005 +39 Misses 14 14 ``` | [Flag](https://app.codecov.io/gh/DASDAE/dascore/pull/415/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DASDAE/dascore/pull/415/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE) | `99.84% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DASDAE#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

d-chambers commented 3 months ago

I also added examples of slope filter in the FK page.

@ahmadtourei or @Shihao-Yuan, do either of you have time to review this in the next few days? Once this merges I think we are good to make another release.

DASDAE / dascore