Closed d-chambers closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.84%. Comparing base (
8fa6680
) to head (620f844
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @ahmadtourei. I implemented your suggestion. I also got thinking and decided to store the origin location as coordinates (not associated with any dimension) rather than attributes. My thinking here is that we may want to support origin being a dataframe in the future, in which case the distance would be the shortest distance to any point in that dataframe. In such a case we would need to store arrays rather than single floats for each coordinate of the origin so this change helps future proof this method.
Description
This PR adds a
add_distance_to
patch method for calculating the distance to a point specified by a series. It can then be used to sort the channels of the patch. See #429.Checklist
I have (if applicable):