search

DASISH / dwan-client-wiredmarker

DASISH Task 5.6. Client for annotation backend (Firefox)
2 stars 4 forks source link

Wrong date and time in annotator log #7

Open 5a2 opened 10 years ago

5a2 commented 10 years ago

I logged in to webannotator (‘v-23-may-2014 "LRECdemo"'). I set my computer’s date to future (6/18/2014 instead of 6/17/2014) and opened the web page http://www.sirp.ee/index.php?option=com_content&view=article&id=22103:2014-06-05-16-00-07&catid=21:teadus&Itemid=26 I did 5 annotations and noticed that the annotator log shows my computer’s date (changed date), not the date of GitHub’s server. The second test was implemented next day (6/18/2014) when I changed my computer date to 6/19/2014 and time one hour forward (14:20 instead of 13:20) and I did 1 annotation. The cached log was showing the annotation time 1 day and 1 hour forward (2014/06/19 14:20:52) from current local time. I did tests on two other web pages as well: http://www.sirp.ee/index.php?option=com_content&view=article&id=22095:2014-06-05-17-24-55&catid=11:varia&Itemid=16 (19/06/2014 instead of 18/06/2014 and 14:26 instead of 13:26) and https://www.riigiteataja.ee/akt/130052012007 (6/19/2014 instead of 6/18/2014 and 14:28 instead of 13:28). The log shows again the annotation time 1 day and 1 hour forward from local time. Today (6/19/2014) I set date for tomorrow (20/06/2014) and as you can see on the screenshot the log shows date 2014/06/20 11:35:58 instead of 2014/06/19 10:35:58. screenshot_annotator log

It was expected that the annotator log reports GitHub’s server date and time. • ‘v-23-may-2014 "LRECdemo"' • Windows 7 • Firefox 30.0

ssvw commented 10 years ago

Thanks for opening this issue.

This is however not a feature that has (so far) been intended to work with the DWAN (Wired-Marker) Firefox add-on. The add-on uses the user's local add-on database to store and retrieve the date that is the valid date on the user's computer at the time of annotation.

We have had a couple of discussions on this issue earlier on, but had concluded that the user should be able to see the "correct" time stamp that gets created when the annotation actually is made.

NB: There is no such thing like a GitHub server that we use for annotation storage. I assume that you mean the MPI server where the REST service is deployed and where the XML representations of the annotations are saved in a database ("remotely" as opposed to "locally" on the user's computer).

@olhsha, @borsna: Any comments on this?

Best,

/ssvw

olhsha commented 10 years ago

Hi, all

As far as i remember we have agreed (not documented in the spec, but somewhere on old wiki, sorry) that the annotation time is the server time of the moment when it was stored. In particular the difference between Tallinn and Nijmegen is one hour as far as I know. E.h. 14:00 vs 13:00 in Nijmegen.

If it works some other way then it is a bug. I will chek it once more.

Best Olha

From: ssvw notifications@github.com<mailto:notifications@github.com> Reply-To: DASISH/dwan-client-wiredmarker reply@reply.github.com<mailto:reply@reply.github.com> Date: Thursday 19 June 2014 10:39 To: DASISH/dwan-client-wiredmarker dwan-client-wiredmarker@noreply.github.com<mailto:dwan-client-wiredmarker@noreply.github.com> Cc: olhsha Olha.Shakaravska@mpi.nl<mailto:Olha.Shakaravska@mpi.nl> Subject: Re: [dwan-client-wiredmarker] Wrong date and time in annotator log (#7)

Thanks for opening this issue.

This is however not a feature that has (so far) been intended to work with the DWAN (Wired-Marker) Firefox add-on. The add-on uses the user's local add-on database to store and retrieve the date that is the valid date on the user's computer at the time of annotation.

We have had a couple of discussions on this issue earlier on, but had concluded that the user should be able to see the "correct" time stamp that gets created when the annotation actually is made.

NB: There is no such thing like a GitHub server that we use for annotation storage. I assume that you mean the MPI server where the REST service is deployed and where the XML representations of the annotations are saved in a database ("remotely" as opposed to "locally" on the user's computer).

@olhshahttps://github.com/olhsha, @borsnahttps://github.com/borsna: Any comments on this?

Best,

/ssvw

— Reply to this email directly or view it on GitHubhttps://github.com/DASISH/dwan-client-wiredmarker/issues/7#issuecomment-46536197.

kristel- commented 10 years ago

Annotation times do not sync. Every annotation gets the login time.

Firefox 28.0 and 30.0, Windows 8, DASISH Web Annotator 2.0