Closed danerkestey closed 5 months ago
General:
Default Parameter:
by = NULL
as the default parameter setting for better handling of multiple samples in a fileFunction Optimization:
glm()
with provoc::provoc_optim()
for fitting purposes. This change is essential to ensure estimates are positive, sum to less than 1 through constrained optimization, and use a linear link function instead of the logistic link function.@examples Chunk:
@examples
section in docs can run in a clean environment, assuming the package is loaded. Include basic code applying this function to Baaijens
as part of the examples.Handling of mutation_defs
:
mutation_defs
to ensure it matches mutation names in the data correctly. This involves checking the matrix dimensions are correctly indexed by mutation and variant names and utilizing provoc::fuse()
or a better implementation for this purpose.mutation_defs
are present to catch potential typos from the user.Data and Lineage Names Handling:
mutation_defs
is provided, considering most users won't have lineage-related columns in their original datasets -> met through fuse
Output Object Requirements:
predict.provoc()
, to facilitate accurate predictions.Parse_Mutations Improvements:
new_muts
vector before loopnew_muts
into a dataframe
Refactored
provoc
to support formula-based inputs and user-defined lineages, improving data handling flexibility and alignment with binomial glm.