Optimization

[bakura10]

Here: https://github.com/DASPRiD/Dash/blob/master/src/Dash/Router/Http/RouteCollection/RouteCollection.php#L102

Implementing IteratorAggregate is much faster than implementing any iterator interface (because PHP needs to call around 5 custom functions at each iteration).

I'm wondering if you cannot implement IteratorAggregate, and do this in RouteCollection:

public function getIterator()
{
    if (!$this->sorted) {
        arsort($this->routes);
        $this->sorted = true;
    }

    return new ArrayIterator($this->routes);
}

[DASPRiD]

And how would the lazy instantiation work in that case?

[bakura10]

You're right, my approach is wrong.

Other optimizations (didn't try them, you should test):

• https://github.com/DASPRiD/Dash/blob/master/src/Dash/Router/Http/RouteMatch.php#L79 : You can use the union operator instead ($ar1 + $ar2). I'm always not sure about the right order.

[DASPRiD]

Indeed, that would work.must be in the other order through to work:

$routeMatch->getParams() + $this->params

[bakura10]

Ok so this should be a bit faster then :).

[danizord]

Good use case for generators :heart_eyes: ZF3 will be 5.4 or 5.5?

[DASPRiD]

5.4…

[DASPRiD]

Which reminds me, we are using the new merging now – can be closed.