search

DASPRiD / Dash

Flexible PSR-7 compliant HTTP router
BSD 2-Clause "Simplified" License
29 stars 9 forks source link

[WIP] Feature/assembly performance improvement #34

Closed DASPRiD closed 10 years ago

DASPRiD commented 10 years ago

This is just a work-in-progress, but demonstrates how we can greatly improve performance for assembling.

The current difference is: master: 2,369 ops per second branch: 17,308 ops per second

Further improvements to follow.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-5.76%) when pulling 46d5d678e84385aba2d66ce911b33e21610a16f8 on feature/assembly-performance-improvement into 33ab876622ad2c4e5d76e4aee6aa37451ecd633f on master.

bakura10 commented 10 years ago

Looks good to me. Anything that prevent you to merge? :)

DASPRiD commented 10 years ago

Getting unit tests back to 100%. But nah, functionality wise this is fine ;)

bakura10 commented 10 years ago

I love this change.A ny benchmark ? :)

DASPRiD commented 10 years ago

@bakura10 Yep, I ran some. Up from 2,000 op/s to 18,000 op/s.

Ocramius commented 10 years ago

@DASPRiD looks good to me, also considering that you removed quite a bit of code from the routes.

bakura10 commented 10 years ago

Nice improvements ! Could we use this in some other parts of the router?

DASPRiD commented 10 years ago

@bakura10 Nope, this is really just an assembly improvement. Next steps will be finalizing features and after that I may see if I can improve performance even further. @Ocramius Thanks for the review, merging :)