search

DASPRiD / Dash

Flexible PSR-7 compliant HTTP router
BSD 2-Clause "Simplified" License
29 stars 9 forks source link

RouteCollection no longer requires a ServiceLocator #38

Closed tyler-sommer closed 10 years ago

tyler-sommer commented 10 years ago

Hi there,

@ocramius requested that Dash be added to tyler-sommer/php-router-benchmark and I've started working on that.

However, to create a RouteCollection I needed a ServiceLocator. This PR makes the ServiceLocator optional for creating a RouteCollection.

I have a strong feeling that this is not actually what I should be doing, any help?

Ocramius commented 10 years ago

Related: tyler-sommer/php-router-benchmark#1

Ocramius commented 10 years ago

@tyler-sommer this is actually a requirement, since routes may be dynamic matchers (DB-based, for example)

tyler-sommer commented 10 years ago

Thanks for the the nudge in the right direction @Ocramius and @DASPRiD!