Initial refactoring, tests still need to be updated

[harikt]

Looks nice :+1: .

[harikt]

@DASPRiD isn't the only use of 5.5 is with ::class . If it is the only reason, it will be nice not to use it :) .

[bakura10]

This is a prototype for zf3 and zf3 will be PHP 5.5. There are use cases for generators in router too

[DASPRiD]

It's also required for yield. Also, ZF3 will require PHP 5.5 anyway.

On 13.02.2015 18:34, Hari K T wrote:

@DASPRiD https://github.com/DASPRiD isn't the only use of 5.5 is with ::class . If it is the only reason, it will be nice not to use it :) .

[bakura10]

By the way @DASPRiD , as Router uses quite extensively the Service Manager, especially with options, could you please try to read my refactor (https://github.com/zendframework/zf2/pull/7133). It includes a new mechanism to allow passing options for invokables AND factories, and I've love you to try it to tell me if it would fit the router needs.

[DASPRiD]

I've read t through it, looks good to me.

On 14.02.2015 11:42, Michaël Gallego wrote:

By the way @DASPRiD https://github.com/DASPRiD , as Router uses quite extensively the Service Manager, especially with options, could you please try to read my refactor (zendframework/zf2#7133 https://github.com/zendframework/zf2/pull/7133). It includes a new mechanism to allow passing options for invokables AND factories, and I've love you to try it to tell me if it would fit the router needs.

— Reply to this email directly or view it on GitHub https://github.com/DASPRiD/Dash/pull/54#issuecomment-74370267.

Ben Scholzen http://www.dasprids.de

[harikt]

may be merge ? Why the wait ?

[harikt]

@DASPRiD what makes you wait not to update unit tests ?

If you like I can look into it. Will introduce phly/http may be that is implementation for zf3 http ?

Thanks

[DASPRiD]

I've got must unit tests in place already.

[harikt]

ok. Then I will leave it.