DASPRiD / Dash

Flexible PSR-7 compliant HTTP router
BSD 2-Clause "Simplified" License
29 stars 9 forks source link

Add service manager as dependency. Not stdlib #58

Closed harikt closed 9 years ago

DASPRiD commented 9 years ago

That was already correct, the service manager is a soft dependency, while stdlib was a hard dependency.

harikt commented 9 years ago

oh man, I have to strongly disagree with you. Check the https://github.com/DASPRiD/Dash/blob/4c74c568a5a3dd7431d95d8e5daa53a9ee62d7c6/src/Dash/Router/RouteCollection/RouteCollection.php#L45 .

Interested to know how you can build a route without using ServiceManager as dependency.

Ocramius commented 9 years ago

Yeah, can't design "soft dependencies".

@DASPRiD that is some kind of concept that we need to get rid of, it is just messy as heck