search

DASPRiD / Dash

Flexible PSR-7 compliant HTTP router
BSD 2-Clause "Simplified" License
29 stars 9 forks source link

Route configuration keys are required #8

Closed Ocramius closed 10 years ago

Ocramius commented 10 years ago

As of https://github.com/DASPRiD/Dash/blob/375ac6bcff45a088ad613fea83030222a369e592/tests/DashTest/Mvc/Router/Http/RouterFactoryTest.php#L27-L33, the configuration accepts numerical indexes for route building.

That is not acceptable due to the nature of Zend\Stdlib\ArrayUtils::merge()

DASPRiD commented 10 years ago

Had that discussed at the conference as well. We perfectly accept that you cannot overwrite values with their numeric index, but only with named parameters. This is also documented in the README.