Closed masarliev closed 7 years ago
This is a BC break which we cannot merge before the next major release.
@DASPRiD version 1.0.0
hasn't been released yet, I don't see a problem with merging this before 1.0.0
?
👎
entity_manager
service name, and every other config key for that matter, which are all in snake_case. eventmanager
would be the only one without the separator.doctrine-orm-module
part, and it has been kept for BC, so you would basically import a wrong convention.@stefanotorresi interesting points made! I guess this is for @DASPRiD to decide as it's his lib...
@stefanotorresi had valid points, and I totally agree with them. Let's stick with what we have.
Coverage remained the same at 26.992% when pulling 02f17f6a13e9c4ed17899ff452bfdcf3d30c5d63 on masarliev:master into 05041506e35cbc4ddd89374ca5998c3544b14a52 on DASPRiD:master.