search

DASPRiD / container-interop-doctrine

Doctrine factories for container-interop
107 stars 25 forks source link

Add global basename support #17

Closed stefanotorresi closed 7 years ago

stefanotorresi commented 7 years ago

This PR add to DriverFactory the ability to use a global_basename key in the driver options, only relevant for Doctrine\Common\Persistence\Mapping\Driver\FileDriver implementations.

This makes possible to correctly configure an instance of Doctrine\ORM\Mapping\Driver\SimplifiedXmlDriver, which requires setting that property to work as intended.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.1%) to 32.105% when pulling fc97f51d909aa0c364ad81fa8b8cf34a4c4f35e6 on stefanotorresi:add-globalbasename-support into 05041506e35cbc4ddd89374ca5998c3544b14a52 on DASPRiD:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.1%) to 32.105% when pulling 77c67e29871b23ecf66b6581c2d6520e8f61131b on stefanotorresi:add-globalbasename-support into 05041506e35cbc4ddd89374ca5998c3544b14a52 on DASPRiD:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.1%) to 32.105% when pulling 16ea1331425799c6301c6537734b949aa6d02a1b on stefanotorresi:add-globalbasename-support into 05041506e35cbc4ddd89374ca5998c3544b14a52 on DASPRiD:master.

stefanotorresi commented 7 years ago

ping @DASPRiD @asgrim

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.2%) to 33.156% when pulling 175e8d5b4f83d2f12b52a93957329445c4a0f85f on stefanotorresi:add-globalbasename-support into 05041506e35cbc4ddd89374ca5998c3544b14a52 on DASPRiD:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.7%) to 33.687% when pulling da65f82dcaabe325f92977184725f91c613777b5 on stefanotorresi:add-globalbasename-support into 05041506e35cbc4ddd89374ca5998c3544b14a52 on DASPRiD:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+12.7%) to 39.722% when pulling 6a10096331fabbecf18dfd84402d90bee3dbeb55 on stefanotorresi:add-globalbasename-support into 05041506e35cbc4ddd89374ca5998c3544b14a52 on DASPRiD:master.

asgrim commented 7 years ago

LGTM :+1: merging