search

DASPRiD / container-interop-doctrine

Doctrine factories for container-interop
107 stars 25 forks source link

Add custom doctrine types before mapping them #23

Closed svycka closed 7 years ago

svycka commented 7 years ago

This allows creating connection without entitymanager and still have working types. Before this fix creating connection throwed exception:

[Zend\ServiceManager\Exception\ServiceNotCreatedException]                                                                       
  Service with name "doctrine.connection.orm_default" could not be created. Reason: Type to be overwritten point does not exist.
coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 45.968% when pulling 9667a4691e2896aca188a6873e2fc20ae056762b on svycka:hotfix/add-custom-types-before-registering into be476163ff0575ac49902aa07706c21a1ff6eab9 on DASPRiD:master.

svycka commented 7 years ago

HHVM failure is not because of this fix

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 46.505% when pulling b3e1c6e49446446b4d9e1cf14dd072e99ff5eed4 on svycka:hotfix/add-custom-types-before-registering into be476163ff0575ac49902aa07706c21a1ff6eab9 on DASPRiD:master.

svycka commented 7 years ago

@DASPRiD @asgrim is it possible to have this released soon?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 46.505% when pulling 5390d85816b9468b0bb5c6e70a17bf055806eb06 on svycka:hotfix/add-custom-types-before-registering into be476163ff0575ac49902aa07706c21a1ff6eab9 on DASPRiD:master.

asgrim commented 7 years ago

Merging as failure came from HHVM and we don't care about that any more. Gonna remove that in another PR.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 46.505% when pulling a51a8a0bf4e397a81b21662d2d6339d6de314abf on svycka:hotfix/add-custom-types-before-registering into 6dd456c33a0b3c272528db94e18917477a58a10a on DASPRiD:master.

asgrim commented 7 years ago

I rebased this as wasn't keen on the merge commit that the GitHub UI's conflict resolution created. This is now merged in a4833d25dcfa42165c4ddec0c7062528206eeadc.