search

DASPRiD / container-interop-doctrine

Doctrine factories for container-interop
107 stars 25 forks source link

Make use of sandrokeil/interop-config #9

Closed prolic closed 7 years ago

prolic commented 8 years ago

this would simplify factory code a lot

/cc @sandrokeil

sandrokeil commented 8 years ago

@DASPRiD If you interested in interop-config, I can bring a PR.

DASPRiD commented 8 years ago

Generally I like simplifying things, but I'm not a huge fan of how interop-config does it, architecture-wise. There is not really a good reason to have that functionality injected via a trait instead of a normal class dependency.

sandrokeil commented 8 years ago

I had an abstract class in prior versions. My decision was to use a trait to increase flexibility e.g. allow other base classes. What's the benefit of having an abstract class which contains the functions of the trait?

DASPRiD commented 8 years ago

As I said rather use a dependency. An abstract class is just as bad.