Logging script reorg

[wildtayne]

prepareUserLogging was removed and reorganized per #35. The resulting scripts are:

• addDDLMonitors.sql
• addLogMgmt.sql
• enableServerLogging.sql (runs ALTER SYSTEM and pg_reload_conf() statements only)

(Fixes #35).

[smurthys]

Consider the following in addDDLMonitors.sql:

• After L12, add the following comments (and remove the current line about initializeDB.sql)

--This script should be run in every database in which DDL activity monitoring is required
-- it should be run after running addUserMgmt.sql

• Rename function updateStudentActivity to updateDDLActivity
• Rename trigger updateStudentActivityTriggerDrop to triggerDDLCommandSqlDrop
• Rename trigger updateStudentActivityTriggerDDL to triggerDDLCommandEnd

For M1, we don't need to worry about dropping old functions when we rename them. We do need to write healing scripts for next releases. (I make the renaming proposals knowing that the Student table will highly likely become User table.)

Consider the following in addLogMgmt.sql:

• After L12, add the following comments (and remove the current line about initializeDB.sql)

--This script should be run in every database in which log management is required
-- it should be run after running enableServerLogging.sql for the server and after running
-- addUserMgmt.sql for the current database

Consider the following in enableServerLogging.sql:

• Remove the reference to initializeDB.sql on L13: this being a server-level script and the functionality being rather simple, there is no need to create a dependency that the script be run in the context of a DB having ClassDB functionality
• Remove the check for superuser: if that is really required duplicate code from helper function so there is no dependency on classdb schema
• I am not sure I understand the comment on L48 "extraneously reload...". I assume START TRANSACTION is required if this .sql file is executed from psql.

[wildtayne]

Thanks for the feedback - I've pushed some commits implementing the changes. I had placed pg_reload_conf() in the transaction block so the superuser check would throw a nicer looking error if the user didn't have permission to execute it. However, it's not really necessary, and requires the dependency on the helper functions or duplicate code.

[afig]

Looks good!