DASSL / ClassDB

An open-source system to let students experiment with relational data
https://dassl.github.io/ClassDB/
Other
7 stars 2 forks source link

Catalog Management functions fail when run by a Student user (W) #105

Closed afig closed 7 years ago

afig commented 7 years ago

Students cannot currently use describe or listTables. An error is reported stating that permission is denied for schema classdb. This is a result of PR #92, which added the use of the foldPgIDto those two functions. Since foldPgIDis in the classdbschema, the two functions in addCatalogMgnt.sql are now unusable by users who do not have access to the classdbschema (including Students).

Some form of foldPgID's behavior should still exist in those two functions, since it would be confusing for users if the function parameters were case-sensitive without quotes.

smurthys commented 7 years ago

Good find. Is the resolution granting execute to students on foldPgID?

afig commented 7 years ago

Unfortunately not, since students do not have any access to the classdb schema. We could either:

smurthys commented 7 years ago

For now, it seems best to duplicate foldPgID in the two functions in question. If we proceed with this solution, I recommend adding clear comments where code is duplicated and also open an issue that code is duplicated (not for M1).