search

DASSL / ClassDB

An open-source system to let students experiment with relational data
https://dassl.github.io/ClassDB/
Other
7 stars 2 forks source link

Add test Banner roster #131

Closed smurthys closed 7 years ago

smurthys commented 7 years ago

The commits in this PR add a sample Banner CSV roster to facilitate testing of the eventual resolution to Issue #51 (add student users in bulk). A README file is also added.

The sample roster is added to the tests folder so it can become part of unit testing the code to add student users in bulk.

afig commented 7 years ago

Overall looks good. This will be definitely be helpful for eventually implementing a solution to above mentioned issue.

The only issue I noticed is that the filename on line 1 of the readme does not match the actual file name.

Another curiosity is that one of the rows contains an asterisk after each instance of "BS Computer Science". I am assuming it is intentional, and carries a meaning, but am not certain.

wildtayne commented 7 years ago

I also think it looks good, besides the one filename/comment Andrew pointed out.

smurthys commented 7 years ago

Thanks for the review. I just pushed a commit renaming the file and correcting the error in the file prologue.

smurthys commented 7 years ago

@afig: The asterisks are generated by Banner. They have meaning outside the context of ClassDB, but I left them in there so the data is representative.

smurthys commented 7 years ago

I will merge the changes tomorrow early morning EDT, just in case @s-aithal sees issues.