DASSL / ClassDB

An open-source system to let students experiment with relational data
https://dassl.github.io/ClassDB/
Other
7 stars 2 forks source link

Attribute names in ER and table schemas should begin with upper case (W) #140

Closed smurthys closed 6 years ago

smurthys commented 6 years ago

Unlike variable names in code, attribute names in ER and table schemas should begin with upper case. See discussion in PR #139 for examples.

A proposal on disposing this issue:

At a higher level, a guidelines of sorts should be developed, probably for all DASSL work not just ClassDB.

Please opine.

KevinKelly25 commented 6 years ago

As I stated in PR #139 I agree with making attribute names in ER and table schemas begin with an uppercase letter.

As @smurthys stated, It would make sense if any file we modify from this point on, if we all agree, should be updated to this new standard. Then before M2 is completed we should go through all files to make sure they are all up to standard.

I agree with @smurthys that we should adopt a consistent guidelines for all of DASSL but if we do want to make guidelines before M2 it would probably be better if we discuss and attempt to solidify them by the end of today's meeting so that our work towards M2 can encompass those guidelines.

smurthys commented 6 years ago

I believe this issue can now be closed.