Several function definitions do not include key attributes (M) - Githubissues

DASSL / ClassDB

An open-source system to let students experiment with relational data

https://dassl.github.io/ClassDB/

Other

8 stars 2 forks source link

Several function definitions do not include key attributes (M) #144

Closed smurthys closed 6 years ago

smurthys commented 6 years ago

Many function definitions (for example, those in addHelpers.sql) do not include appropriate attributes.

All function definitions should include the following attribute values if the default value is not appropriate:

IMMUTABLE, STABLE
RETURNS NULL ON NULL INPUT
SECURITY DEFINER
ROWS

The nature of this issue is similar to that of Issue #140:

No one person can fix this issue due its nature, Rather, anyone who touches any file should address this issue.
All future development should comply with this requirement
All reviews should factor in this requirement
This issue should be closed at end of M2, because incorrect attribute specification should be covered in individual PRs

smurthys commented 6 years ago

I believe this issue can be closed now.